linux-kernel - Re: [tip:x86/asm] x86/fpu: Fix early FPU command-line parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jan 2016 13:01:37 -0800
From:	Dave Hansen <dave.hansen@...ux.intel.com>
To:	Yu-cheng Yu <yu-cheng.yu@...el.com>, Borislav Petkov <bp@...en8.de>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org,
	torvalds@...ux-foundation.org, tglx@...utronix.de, oleg@...hat.com,
	ravi.v.shankar@...el.com, fenghua.yu@...el.com, mingo@...nel.org,
	quentin.casasnovas@...cle.com, bp@...e.de, hpa@...or.com,
	luto@...capital.net, sai.praneeth.prakhya@...el.com,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/asm] x86/fpu: Fix early FPU command-line parsing

On 01/15/2016 12:50 PM, Yu-cheng Yu wrote:
>> > 
>> > This could certainly be improved: we're iterating over the *whole*
>> > command line each time for each option unconditionally instead of
>> > iterating word by word and comparing it with all strings.
>> > 
>> > We'd need something like cmdline_for_each_word() or so, though...
>> > 
> That is a good point. I will work on it.

I really don't think we need to do this.  It's code that runs *ONCE* at
boot time.  Let's not work on optimizing it unless we have some acute need.