linux-kernel - [PATCH] x86/mcheck/AMD: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Jan 2016 09:01:36 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>
Cc:	kbuild-all@...org, tony.luck@...el.com, bp@...en8.de,
	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] x86/mcheck/AMD: fix boolreturn.cocci warnings

arch/x86/kernel/cpu/mcheck/mce_amd.c:93:9-10: WARNING: return of 0/1 in function 'is_shared_bank' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@....com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 mce_amd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/kernel/cpu/mcheck/mce_amd.c
+++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c
@@ -90,7 +90,7 @@ static inline bool is_shared_bank(int ba
 	 * control over the respective MCA bank
 	 */
 	if (mce_flags.smca)
-		return 0;
+		return false;
 
 	/* Bank 4 is for northbridge reporting and is thus shared */
 	return (bank == 4);