linux-kernel - [PATCH RESEND] omap_hdq: fix usecount handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Jan 2016 13:48:50 +0100
From:	Andreas Kemnade <andreas@...nade.info>
To:	Evgeniy Polyakov <zbr@...emap.net>, hns@...delico.com,
	Fabian Frederick <fabf@...net.be>, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Cc:	Andreas Kemnade <andreas@...nade.info>
Subject: [PATCH RESEND] omap_hdq: fix usecount handling

hdq_usecount was set to zero after a successful read, so
omap_hdq_put could not properly free resources which leads
e.g. to increasing usecounts in lsmod output

Signed-off-by: Andreas Kemnade <andreas@...nade.info>
---
 drivers/w1/masters/omap_hdq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
index 0e2f43b..a2eec97 100644
--- a/drivers/w1/masters/omap_hdq.c
+++ b/drivers/w1/masters/omap_hdq.c
@@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
 
 	hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
 			      ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
-	hdq_data->hdq_usecount = 0;
 
 	/* Write followed by a read, release the module */
 	if (hdq_data->init_trans) {
-- 
2.1.4