linux-kernel - Re: [RESEND PATCH 0/2] crypto: sunxi-ss: fix 64-bit compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 16 Jan 2016 21:32:45 +0100
From:	Corentin LABBE <clabbe.montjoie@...il.com>
To:	Andre Przywara <andre.przywara@....com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Chen-Yu Tsai <wens@...e.org>, Arnd Bergmann <arnd@...db.de>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S . Miller" <davem@...emloft.net>,
	linux-sunxi@...glegroups.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [RESEND PATCH 0/2] crypto: sunxi-ss: fix 64-bit compilation

Le 08/01/2016 12:24, Andre Przywara a écrit :
> (resending to add linux-crypto, patches unchanged)
> 
> Hi,
> 
> these two patches provide a different approach to an issue I tried
> to fix lately [1].
> Instead of casting everything I now promote local types to size_t, so
> that the min3() arguments naturally match in type.
> As size_t is defined as "unsigned int" on 32-bit architectures
> anyway, that actually does not change anything there, but instead
> provides a clean approach to get it compiled for arm64.
> 
> I split this up because 1/2 seems much cleaner to me than 2/2, so we
> can have a separate discussion/merge process on this.
> 
> Cheers,
> Andre.
> 
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/395689.html
> 
> Andre Przywara (2):
>   crypto: sunxi-ss-cipher: promote variables to match types in min3()
>     calls
>   crypto: sunxi-ss-hash: promote variables to match types in min3()
>     calls
> 
>  drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 20 ++++++++++----------
>  drivers/crypto/sunxi-ss/sun4i-ss-hash.c   | 12 ++++++------
>  drivers/crypto/sunxi-ss/sun4i-ss.h        |  2 +-
>  3 files changed, 17 insertions(+), 17 deletions(-)
> 

Hello

Sorry for this late answer.

I am in trouble with those patch, so we have with Andre a long conversation about it.
Basically, sun4i-ss will never be available on 64bits platform. (A64 will have a totally new crypto engine).
So letting it to compile under 64bit arch is only useful when goal is to add COMPILE_TEST for it.
But COMPILE_TEST cannot simply be added with those patch since some arches (x86/x86_64 at least) does not have writesl/readsl available.
The conclusion is that it is simpler to block 64bit build for sun4i-ss.

Regards

LABBE Corentin