lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Jan 2016 18:48:44 +0100 From: Borislav Petkov <bp@...e.de> To: Alexander Kuleshov <kuleshovmail@...il.com> Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org, Andy Lutomirski <luto@...nel.org>, Denys Vlasenko <dvlasenk@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] x86/traps.c: refactor preemption and interrupt flag handling On Sun, Jan 17, 2016 at 07:09:44PM +0600, Alexander Kuleshov wrote: > The arch/x86/kernel/traps.c contains definition of two pair of helpers > conditional_{sti,cli} to enable/disable interrupts depends on state of > the interrupt flag and *preempt* versions of these helpers. > > This patch tries to make the preemption and interrupt flag handling more > readable by removing preempt_conditional_sti() and > preempt_conditional_cli() helpers and usage preempt_disable() and > preempt_enable_no_resched() for preemption in place, instead of these helpers. > > The contitional_sti() and conditional_cli() are renamed to more understandable > names: cond_local_irq_enable() and cond_local_irq_disable() respectively. So > so that one doesn't have to go and lookup the function definition when > looking at the code flow. > > Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com> > Suggested-by: Borislav Petkov <bp@...e.de> > --- > Changelog v2: > 1. Use preempt_enable_no_resched() instead of sched_preempt_enable_no_resched() > > arch/x86/kernel/traps.c | 47 +++++++++++++++++++---------------------------- > 1 file changed, 19 insertions(+), 28 deletions(-) Applied, thanks. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --
Powered by blists - more mailing lists