linux-kernel - Re: [PATCH v3] pipe: limit the per-user amount of pages allocated in pipes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jan 2016 16:29:46 +0100
From:	Willy Tarreau <w@....eu>
To:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc:	lkp@...el.com, kbuild-all@...org, viro@...iv.linux.org.uk,
	torvalds@...ux-foundation.org, socketpair@...il.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] pipe: limit the per-user amount of pages allocated in pipes

On Tue, Jan 19, 2016 at 12:12:44AM +0900, Tetsuo Handa wrote:
> Willy Tarreau wrote:
> > On Mon, Jan 18, 2016 at 08:22:10PM +0800, kbuild test robot wrote:
> > > Hi Willy,
> > > 
> > > [auto build test WARNING on linus/master]
> > > [also build test WARNING on next-20160118]
> > > [cannot apply to tip/sched/core v4.4]
> > > [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
> > 
> > Well, I don't understand how to read the output here, I'm sorry. Since this
> > patch modifies the user_struct, it has a dependency on the following patch
> > just merged into Linus tree :
> > 
> >    712f4aa ("unix: properly account for FDs passed over unix sockets")
> > 
> > That's probably why you have the "cannot apply" error above.
> 
> The output says that description for newly added field is missing.
> I think adding some description like
> 
>   *      @fasync_readers: reader side fasync
>   *      @fasync_writers: writer side fasync
>   *      @bufs: the circular array of pipe buffers
> + *      @user: the user who created this pipe
>   **/
>  struct pipe_inode_info {
>          struct mutex mutex;
> 
> will fix.

Ah you're right, I've checked the other warnings that were reported around
and that's it. I wasn't aware that a bot was reading comments, I thought it
was a build warning.

I'm going to resend a v4.

Thanks,
Willy