linux-kernel - Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 Jan 2016 01:15:42 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Richard Weinberger <richard@....at>
Cc:	user-mode-linux-devel@...ts.sourceforge.net,
	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/22] iio: imu: Fix dependencies for !HAS_IOMEM archs

On ma, 2016-01-25 at 23:24 +0100, Richard Weinberger wrote:
> --- a/drivers/iio/imu/inv_mpu6050/Kconfig
> +++ b/drivers/iio/imu/inv_mpu6050/Kconfig

>  config INV_MPU6050_IIO
>  	tristate "Invensense MPU6050 devices"
>  	depends on I2C && SYSFS
> +	depends on I2C_MUX

Nit: if I parsed the v4.5-rc1 tree correctly I2C_MUX depends I2C. So
just
	depends on I2C_MUX && SYSFS

should also do the trick. Is it clearer to mention both I2C and I2C_MUX
explicitly?

(Likewise for 17/22.)

>  	select IIO_BUFFER
>  	select IIO_TRIGGERED_BUFFER
> -	select I2C_MUX
>  	help
>  	  This driver supports the Invensense MPU6050 devices.

(evolution 3.16.5 hates replying to plain text messages, so I've lost a
line of context after fiddling with your message here.)


Paul Bolle