linux-kernel - Re: [PATCH] mm: vmscan: do not clear SHRINKER_NUMA_AWARE if nr_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Jan 2016 13:52:18 -0500
From:	Johannes Weiner <hannes@...xchg.org>
To:	Vladimir Davydov <vdavydov@...tuozzo.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: vmscan: do not clear SHRINKER_NUMA_AWARE if
 nr_node_ids == 1

On Wed, Jan 27, 2016 at 07:47:22PM +0300, Vladimir Davydov wrote:
> Currently, on shrinker registration we clear SHRINKER_NUMA_AWARE if
> there's the only NUMA node present. The comment states that this will
> allow us to save some small loop time later. It used to be true when
> this code was added (see commit 1d3d4437eae1b ("vmscan: per-node
> deferred work")), but since commit 6b4f7799c6a57 ("mm: vmscan: invoke
> slab shrinkers from shrink_zone()") it doesn't make any difference.
> Anyway, running on non-NUMA machine shouldn't make a shrinker NUMA
> unaware, so zap this hunk.
> 
> Signed-off-by: Vladimir Davydov <vdavydov@...tuozzo.com>

Acked-by: Johannes Weiner <hannes@...xchg.org>