linux-kernel - [PATCH RFC] blk-mq: no need to modify bt->wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 29 Jan 2016 01:12:29 -0500
From:	Wenbo Wang <mail_weber_wang@....com>
To:	axboe@...com
Cc:	sagig@....mellanox.co.il, Wenbo Wang <mail_weber_wang@....com>,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH RFC] blk-mq: no need to modify bt->wake_index if someone has updated it

If someone else has found active waitqueue and updated
bt->wake_index, do not modify it again. This saves an
atomic read.

Signed-off-by: Wenbo Wang <mail_weber_wang@....com>
CC: linux-block@...r.kernel.org
CC: linux-kernel@...r.kernel.org
---
 block/blk-mq-tag.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index abdbb47..5ed9111 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -356,16 +356,15 @@ unsigned int blk_mq_get_tag(struct blk_mq_alloc_data *data)
 
 static struct bt_wait_state *bt_wake_ptr(struct blk_mq_bitmap_tags *bt)
 {
-	int i, wake_index;
+	int i, wake_index, orig_wake_index;
 
-	wake_index = atomic_read(&bt->wake_index);
+	orig_wake_index = wake_index = atomic_read(&bt->wake_index);
 	for (i = 0; i < BT_WAIT_QUEUES; i++) {
 		struct bt_wait_state *bs = &bt->bs[wake_index];
 
 		if (waitqueue_active(&bs->wait)) {
-			int o = atomic_read(&bt->wake_index);
-			if (wake_index != o)
-				atomic_cmpxchg(&bt->wake_index, o, wake_index);
+			if (wake_index != orig_wake_index)
+				atomic_cmpxchg(&bt->wake_index, orig_wake_index, wake_index);
 
 			return bs;
 		}
-- 
1.8.3.1
---
Not seeing too much benifit from this patch, but it makes the logic here more clear