linux-kernel - Re: [PATCH] nouveau: need to handle failed allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 28 Jan 2016 19:08:05 -0500
From:	Ilia Mirkin <imirkin@...m.mit.edu>
To:	Insu Yun <wuninsu@...il.com>
Cc:	David Airlie <airlied@...ux.ie>, Ben Skeggs <bskeggs@...hat.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Ville Syrjälä <ville.syrjala@...ux.intel.com>,
	maarten.lankhorst@...ux.intel.com,
	Thierry Reding <treding@...dia.com>,
	Alexandre Courbot <acourbot@...dia.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	taesoo@...ech.edu, yeongjin.jang@...ech.edu, insu@...ech.edu,
	changwoo@...ech.edu
Subject: Re: [PATCH] nouveau: need to handle failed allocation

On Thu, Jan 28, 2016 at 7:09 PM, Insu Yun <wuninsu@...il.com> wrote:
> drm_property_create_range can be failed in memory pressure.
> So, it needs to be handled.
>
> Signed-off-by: Insu Yun <wuninsu@...il.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_display.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
> index 24be27d..26b4902 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_display.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_display.c
> @@ -443,6 +443,12 @@ nouveau_display_create_properties(struct drm_device *dev)
>         /* -100..+100 */
>         disp->color_vibrance_property =
>                 drm_property_create_range(dev, 0, "color vibrance", 0, 200);
> +
> +       if (!disp->underscan_hborder_property ||
> +                       !disp->underscan_vborder_property ||
> +                       !disp->vibrant_hue_property ||
> +                       !disp->color_vibrance_property)
> +               return;

Aren't we at the end of the function anyways?

>  }
>
>  int
> --
> 1.9.1
>