linux-kernel - Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 29 Jan 2016 23:02:27 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Bijosh Thykkoottathil <bijosh.t@...mail.com>
Cc:	gregkh@...uxfoundation.org, christian.gromm@...rochip.com,
	andrey.shvetsov@....de, adrianremonda@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: coding style cleanups for
 staging/most/mostcore driver

On Fri, Jan 29, 2016 at 10:38:42PM +0530, Bijosh Thykkoottathil wrote:
> From: Bijosh Thykkoottathil <bijosh.t@...mail.com>

You do not need this From: line here. The email From: header is
sufficient.

> 
> Fixes following coading style issues reported by the check patch script.
>     - ERROR: Macros with complex values should be enclosed in parentheses
>     - CHECK: struct mutex definition without comment
>     - CHECK: spinlock_t definition without comment
>     - CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code
>       rather than BUG() or BUG_ON()
>     - WARNING: storage class should be at the beginning of the declaration

You are doing too many things in one patch. Please break them up into
separate patches. Each patch should do only one type of change.

regards
sudip