linux-kernel - RE: [PATCH][v2] ACPI: Do not report _OSI("Darwin") when acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Feb 2016 09:13:25 +0000
From:	"Chen, Yu C" <yu.c.chen@...el.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
CC:	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>,
	"matthew.garrett@...ula.com" <matthew.garrett@...ula.com>,
	"Zhang, Rui" <rui.zhang@...el.com>
Subject: RE: [PATCH][v2] ACPI: Do not report _OSI("Darwin") when
 acpi_osi=!Darwin provided

Thanks Andy,

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> Sent: Monday, February 01, 2016 4:54 PM
> To: Chen, Yu C
> Cc: linux-acpi@...r.kernel.org; linux-kernel@...r.kernel.org; Rafael J.
> Wysocki; Len Brown; matthew.garrett@...ula.com; Zhang, Rui
> Subject: Re: [PATCH][v2] ACPI: Do not report _OSI("Darwin") when
> acpi_osi=!Darwin provided
> 
> On Mon, Feb 1, 2016 at 4:26 AM, Chen Yu <yu.c.chen@...el.com> wrote:
> > Commit 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") always
> > reports positive value when Apple hardware queries _OSI("Darwin").
> > But sometimes the users might want to tell the hardware they don't
> > need the Darwin feature, for example, users may leverage the hardware
> > to power off the Thunderbolt, by appending acpi_osi=!Darwin in command
> > line, thus Apple hardware regards it as an incompatible OS X system,
> > hence turns off the Thunderbolt.
> 
> 
> > +static bool acpi_osi_setup_disabled(char *str) {
> > +       int i;
> > +       struct osi_setup_entry *osi;
> > +
> > +       if (!str)
> > +               return false;
> > +
> > +       for (i = 0; i < OSI_STRING_ENTRIES_MAX; i++) {
> > +               osi = &osi_setup_entries[i];
> > +               if (!strcmp(osi->string, str)) {
> 
> Seems like we have one more user for
> http://www.spinics.net/lists/kernel/msg2157535.html
[Yu] This is nice, I can convert this patch to use match_string, and
may I add my patch into your patchset? I saw there are some modifications
on drivers in your patchset above. 
> 
> > +                       if (!osi->enable)
> > +                               return true;
> > +                       else
> > +                               return false;
> 
> return !osi->enable;
[Yu] OK.
> 
> > +               }
> > +       }
> > +
> > +       return false;
> > +}
>