linux-kernel - Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Feb 2016 11:39:31 +0100
From:	Maxime Coquelin <mcoquelin.stm32@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Patrice CHOTARD <patrice.chotard@...com>,
	Mark Rutland <mark.rutland@....com>,
	Rob Herring <robh+dt@...nel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andreas Färber <afaerber@...e.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Daniel Thompson <daniel.thompson@...aro.org>,
	Bruno Herrera <bruherrera@...il.com>
Subject: Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support

2016-02-01 11:21 GMT+01:00 Arnd Bergmann <arnd@...db.de>:
> On Wednesday 27 January 2016 14:16:32 Linus Walleij wrote:
>> On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin
>> <mcoquelin.stm32@...il.com> wrote:
>>
>> > This patch adds pinctrl and GPIO support to STMicroelectronic's STM32
>> > family of MCUs.
>> >
>> > While it only supports STM32F429 for now, it has been designed to enable
>> > support of other MCUs of the family (e.g. STM32F746).
>> >
>> > Acked-by: Patrice Chotard <patrice.chotard@...com>
>> > Signed-off-by: Maxime Coquelin <mcoquelin.stm32@...il.com>
>>
>> This patch applied for kernel v4.6.
>>
>
> This breaks the kernel build, please revert:
>
> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory

Right, I missed to notify this dependency to Linus, sorry about that.
This dependency is no more needed, so I could just move the macros to
the driver side.

Note that I also noticed a breakage at build time due to field
renaming in gpio_chip structure (dev -> parent).

I propose to rebase the series and move the defines into the driver.
Is it ok for you?

Regards,
Maxime