linux-kernel - Re: [PATCH] affs: add kunmap in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2016 02:24:36 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Insu Yun <wuninsu@...il.com>
Cc:	akpm@...ux-foundation.org, fabf@...net.be, osandov@...ndov.com,
	geert@...ux-m68k.org, tsgatesv@...il.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	taesoo@...ech.edu, yeongjin.jang@...ech.edu, insu@...ech.edu,
	changwoo@...ech.edu
Subject: Re: [PATCH] affs: add kunmap in error path

On Mon, Feb 01, 2016 at 08:55:17PM -0500, Insu Yun wrote:
> When error occurs, it needs to unmap page.

Point, but...  I'm not sure there's any point in keeping it mapped all
along.  After all, what we are doing is a bunch of memcpy() into the
parts of page, so kmap_atomic()/kunmap_atomic() just around memcpy
would do just fine.