linux-kernel - Re: [PATCH v2] vsprintf: automatic parameters for %pIS via 'a'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Feb 2016 15:37:12 -0800
From:	Joe Perches <joe@...ches.com>
To:	"Jason A. Donenfeld" <Jason@...c4.com>
Cc:	Daniel Borkmann <daniel@...earbox.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux@...musvillemoes.dk, andriy.shevchenko@...ux.intel.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] vsprintf: automatic parameters for %pIS via 'a'

On Thu, 2016-02-04 at 00:29 +0100, Jason A. Donenfeld wrote:
> This patch adds a variable 'a' which indicates that the 'p',
> 'f', and 's' options should be toggled on or off depending on
> whether or not those parameters are actually valid inside the
> passed sockaddr.

trivia:

> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
[]
> @@ -1225,9 +1234,15 @@ char *ip4_addr_string_sa(char *buf, char *end, const struct sockaddr_in *sa,
[]
> +	if (have_a)
> +		have_p = sa->sin_port != 0;
> +

different style than the v6 tests