linux-kernel - Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Feb 2016 10:26:07 -0700
From:	Jeffrey Merkey <jeffmerkey@...il.com>
To:	Don Zickus <dzickus@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	atomlin@...hat.com, cmetcalf@...hip.com, fweisbec@...il.com,
	hidehiro.kawai.ez@...achi.com, mhocko@...e.cz, tj@...nel.org,
	uobergfe@...hat.com
Subject: Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection

On 2/3/16, Don Zickus <dzickus@...hat.com> wrote:
> On Tue, Feb 02, 2016 at 03:40:34PM -0700, Jeffrey Merkey wrote:
>> >
>> > Please remember to add version history, so I can tell what changed.
>> >
>>
>> What command do I give to git when it creates the patch from git
>> format-patch that outputs what you are looking for or do I have to add
>> that manually.  The diff of files changed?
>
> Sorry I forgot to respond to this part.  This is usually just a manual text
> that folks add to explain what changed between different versions of the
> patch.  It is difficult to re-review a patch from scratch all the time.  It
> is nice to have a little blurb stating what changed to help focus my
> review.
>
> Now this patch is small enough, it doesn't matter, but it is a nice habit
> to
> get into.
>
> Cheers,
> Don
>

I looked over some other patches on the list and see what you are
refering to.  It will be included in the future patches.

Thank you for explaining this to me.

Jeff