lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Feb 2016 03:22:04 +0000 From: Ofer Heifetz <oferh@...vell.com> To: Marcin Wojtas <mw@...ihalf.com>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> CC: Gregory CLEMENT <gregory.clement@...e-electrons.com>, Jason Cooper <jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, "arm@...nel.org" <arm@...nel.org>, "Catalin Marinas" <catalin.marinas@....com>, Will Deacon <will.deacon@....com>, Jonathan Corbet <corbet@....net>, Mark Rutland <mark.rutland@....com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Omri Itach <omrii@...vell.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Nadav Haklai <nadavh@...vell.com>, Hans de Goede <hdegoede@...hat.com>, Lior Amsalem <alior@...vell.com>, "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>, Jiri Slaby <jslaby@...e.com>, Tejun Heo <tj@...nel.org>, Wilson Ding <dingwei@...vell.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: RE: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port Hi Marcin, I think it is a partial fix since once QA started to use this patch and found that /proc/interrupts prints serial interrupt string multiple times which is clobbering the print. /Ofer -----Original Message----- From: Marcin Wojtas [mailto:mw@...ihalf.com] Sent: Thursday, February 04, 2016 12:23 AM To: Thomas Petazzoni; Ofer Heifetz Cc: Gregory CLEMENT; Jason Cooper; Andrew Lunn; Sebastian Hesselbarth; arm@...nel.org; Catalin Marinas; Will Deacon; Jonathan Corbet; Mark Rutland; devicetree@...r.kernel.org; linux-ide@...r.kernel.org; Greg Kroah-Hartman; Omri Itach; linux-kernel@...r.kernel.org; Nadav Haklai; Hans de Goede; Lior Amsalem; linux-serial@...r.kernel.org; Jiri Slaby; Tejun Heo; Wilson Ding; linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port I'm sorry, indeed, I was the one to overlook - there was a lot going on in a thread and I missed it. Ofer, as you found out that IRQF_SHARED help booting ubuntu - do you think it's a hack or fix? Best regards, Marcin 2016-02-03 23:02 GMT+01:00 Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>: > Dear Marcin Wojtas, > > On Wed, 3 Feb 2016 22:41:15 +0100, Marcin Wojtas wrote: >> Hi Gregory, >> >> > + port->irq = irq->start; >> > + port->irqflags = 0; >> >> Same request as for v1, which you must have overlooked: >> port->irqflags = IRQF_SHARED; > > Gregory didn't overlook this comment you made on v1, he even replied > to it. Please check Gregory's reply to your review. > > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
Powered by blists - more mailing lists