linux-kernel - RE: [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Feb 2016 13:30:25 +0530
From:	"Sricharan" <sricharan@...eaurora.org>
To:	"'Wolfram Sang'" <wsa@...-dreams.de>
Cc:	<devicetree@...r.kernel.org>, <architt@...eaurora.org>,
	<linux-arm-msm@...r.kernel.org>, <ntelkar@...eaurora.org>,
	<galak@...eaurora.org>, <linux-kernel@...r.kernel.org>,
	<andy.gross@...aro.org>, <linux-i2c@...r.kernel.org>,
	<iivanov@...sol.com>, <agross@...eaurora.org>,
	<dmaengine@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c_msgs without a stop bit

Hi Wolfram,

> -----Original Message-----
> From: linux-arm-kernel [mailto:linux-arm-kernel-
> bounces@...ts.infradead.org] On Behalf Of Wolfram Sang
> Sent: Friday, February 05, 2016 1:39 AM
> To: Sricharan
> Cc: devicetree@...r.kernel.org; architt@...eaurora.org; linux-arm-
> msm@...r.kernel.org; ntelkar@...eaurora.org; galak@...eaurora.org;
> linux-kernel@...r.kernel.org; andy.gross@...aro.org; linux-
> i2c@...r.kernel.org; iivanov@...sol.com; agross@...eaurora.org;
> dmaengine@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c_msgs
> without a stop bit
> 
> Hi,
> 
> > Ah, so what I meant above is there is no 'STOP' bit between each msg
> > in i2c_msgs, but 'REAPEATED_START' still holds true.  We are sending
> > 'START' bit for each msg.
> > So these is how each msg in i2c_msg is sent,
> >
> > |------MSG1--------|-----MSG2---------|------MSG3------------|
> >
> >   |START|DATA|------|START|DATA|---|START|DATA|STOP|
> >
> > If my commit text does not make this clear, I  can reword that ?
> 
> OK, now this looks to me perfectly fine: A number of *messages*
> concatenated into one *transfer* by repeated start. That's the way it
should
> be.
> 
> So, I'd simply remove these words:
> 
> "The QUP i2c hardware has no way to inform that there should not be a
> 'STOP' at the end of transaction. The only way to implement this is to
> coalesce all the i2c_msg in i2c_msgs in to one transaction and transfer
them."
> 
> This sounded like the HW needed a special handling, so I was under the
> impression REP_START was broken. However, unless I misunderstood
> something again, this now sounds like the standard case and we can keep
> the commit message simple. If you are okay with that, I can update it
here,
> no need to resend.
> 
      Yes the above modified commit text looks perfect to be updated and
thanks
      for the update as well.

Regards,
 Sricharan