linux-kernel - Re: [PATCH] hid:Add warning message if sysfs group is not created for passed kobject in the function, mt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 5 Feb 2016 14:37:58 +0100 (CET)
From:	Jiri Kosina <jikos@...nel.org>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
cc:	Nicholas Krause <xerofoify@...il.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid:Add warning message if sysfs group is not created
 for passed kobject in the function, mt_probe

On Fri, 5 Feb 2016, Benjamin Tissoires wrote:

> > This adds a warning message stating that the sysfs group was not
> > able to be created for the passed hid_device structure pointer
> > with dev_warn.
> > 
> > Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> > ---
> >  drivers/hid/hid-multitouch.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> > index 296d499..b2b2451 100644
> > --- a/drivers/hid/hid-multitouch.c
> > +++ b/drivers/hid/hid-multitouch.c
> > @@ -1133,6 +1133,8 @@ static int mt_probe(struct hid_device *hdev, const struct hid_device_id *id)
> >  		return ret;
> >  
> >  	ret = sysfs_create_group(&hdev->dev.kobj, &mt_attribute_group);
> > +	if (ret)
> > +		dev_warn(&hdev->dev, "Cannot allocate sysfs group for %s\n", hdev->name);
> 
> Just nitpicking here. Checkpatch.pl complains about a line over 80
> characters here. Could you (or maybe just Jiri) fix that?
> 
> Otherwise:
> Reviewed-by: Benjamin Tissoires <benajmin.tissoires@...hat.com>

Thanks. I've reformatted the source (and also changelog a bit) and 
applied.

-- 
Jiri Kosina
SUSE Labs