linux-kernel - Re: [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 5 Feb 2016 14:09:17 -0800
From:	Alexandra Yates <alexandra.yates@...ux.intel.com>
To:	Jean Delvare <jdelvare@...e.de>, Wolfram Sang <wsa@...-dreams.de>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO

Hi Jean,

Thank you for your review and feedback.

On 02/05/2016 01:48 AM, Jean Delvare wrote:
> On Fri, 5 Feb 2016 00:27:46 +0100, Wolfram Sang wrote:
>> On Thu, Feb 04, 2016 at 03:06:55PM -0800, Alexandra Yates wrote:
>>> Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
>>> resources have been moved to reside under the i801 SMBus host
>>> controller whereas previously they were under the LPC device.
>>>
>>> This patch adds Intel lewisburg SMBus support for iTCO device.
>>>
>>> Signed-off-by: Alexandra Yates <alexandra.yates@...ux.intel.com>
>>
>> Please state what has changed in v2 of this patch?
>
> Yes, Alexandra, please always include a changelog (between the ---
> separator and the diffstat) when posting patch updates.
>
> In this case there is no code change, the only change is the subject.

correct
>
> If I understand correctly, this is a fixup for commit
> cdc5a3110e7c3ae793f367285789a6bc39c962dc ("i2c: i801: add Intel
> Lewisburg device IDs") which should have included these changes. If so,
> please mention it in the commit message. It may also make sense to tag
> the patch for stable [v4.4].

It is an addition to that commit, at the time I submitted the commit I 
wasn't aware that this portion was needed to load dynamically since this 
part of the code was in flux as well.  As it is the driver loads using 
modprobe. I'll add that to the commit message to make it clear and 
resend the patch.

>
> Reviewed-by: Jean Delvare <jdelvare@...e.de>
>
> Thanks,
>

-- 
Thank you,
<Alexandra>