linux-kernel - Re: [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap, irq chip locally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Feb 2016 15:50:06 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	<lee.jones@...aro.org>, <alexandre.belloni@...e-electrons.com>,
	<k.kozlowski@...sung.com>, <javier@....samsung.com>,
	<broonie@...nel.org>, <gregkh@...uxfoundation.org>,
	<a.zummo@...ertech.it>
CC:	<cw00.choi@...sung.com>, <linux-kernel@...r.kernel.org>,
	<rtc-linux@...glegroups.com>
Subject: Re: [PATCH V4 6/6] rtc: max77686: move initialisation of rtc regmap,
 irq chip locally


On Saturday 06 February 2016 08:07 PM, Laxman Dewangan wrote:
> -	ret = devm_request_threaded_irq(&pdev->dev, info->virq, NULL,
> -					max77686_rtc_alarm_irq, 0,
> -					"rtc-alarm1", info);
> -	if (ret < 0)
> +	ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0,
> +				   "rtc-alarm1", info);
> +	if (ret < 0) {
>   		dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n",
>   			info->virq, ret);
> +		goto err_rtc;
> +	}
> +
> +	return 0;
>   
>   err_rtc:

Oops.. I wish I should have called regmap_irq_put_virq(info->virq); here.

Please let me know if I can respin this patch only instead of entire series.