linux-kernel - Re: [PATCH v2] mmc: pxamci: fix the device-tree probe deferral path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 08 Feb 2016 15:16:15 +0100
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mmc: pxamci: fix the device-tree probe deferral path

Ulf Hansson <ulf.hansson@...aro.org> writes:

> On 6 February 2016 at 22:14, Robert Jarzmik <robert.jarzmik@...e.fr> wrote:
>> When the gpio driver is probed after the mmc one, the read/write gpio
>> and card detection one return -EPROBE_DEFER. Unfortunately, the memory
>> region remains requested, and upon the next probe, the probe will fail
>> anyway with -EBUSY.
>>
>> Fix this by releasing the memory resource upon probe failure.
>>
>> More broadly, this patch uses devm_*() primitives whenever possible in
>> the probe function.
>
> There's actually also clocks and regulators that may be converted to
> use the devm* functions.
> Do you want to do that as a part of this patch as well? Otherwise I
> can apply as is.
Yes, I will add the regulator and clock in this patch, you're right, this makes
sense to me, v3 on its way.

Cheers.

--
Robert