linux-kernel - Re: [PATCH] staging: sm750fb: Fix comments style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 7 Feb 2016 18:54:26 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	sebastian.lawniczak@...oo.com
Cc:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Teddy Wang <teddy.wang@...iconmotion.com>,
	linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Fix comments style

On Wed, Dec 02, 2015 at 08:18:11PM +0100, sebastian.lawniczak@...oo.com wrote:
> From: Sebastian Lawniczak <sebastian.lawniczak@...oo.com>
> 
> Fix warnings reported by checkpatch.pl in block comments.
> 
> Signed-off-by: Sebastian Lawniczak <sebastian.lawniczak@...oo.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 70 +++++++++++++++++++----------------
>  1 file changed, 39 insertions(+), 31 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 0331d34..01ddf44 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -86,8 +86,10 @@ static void setMemoryClock(unsigned int frequency)
>  		return;
>  
>  	if (frequency) {
> -		/* Set the frequency to the maximum frequency that the DDR Memory can take
> -		which is 336MHz. */
> +		/*
> +		* Set the frequency to the maximum frequency that the DDR Memory can take
> +		* which is 336MHz.
> +		*/

It should look like:
		/*
		 * Set the frequency to the maximum frequency that the DDR Memory can take
		 * which is 336MHz.
		 */

So I can't take this patch, sorry.

Please fix it up and resend.

thanks,

greg k-h