linux-kernel - Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Feb 2016 18:19:08 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>, lee.jones@...aro.org,
	alexandre.belloni@...e-electrons.com, k.kozlowski@...sung.com,
	javier@....samsung.com, gregkh@...uxfoundation.org,
	a.zummo@...ertech.it, cw00.choi@...sung.com,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com
Subject: Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq

On Mon, Feb 08, 2016 at 10:26:20PM +0530, Laxman Dewangan wrote:
> Adding Thomas in the discussion.

> >This does not explain why anyone would ever want to use this interface
> >(which was my question), why would anyone ever want to do this as a
> >separate step?

> OK, so you want to say that irq_domain_remove() should take care of doing
> unmap also?

My main focus is on the regmap-irq interface you are trying to add - why
would a user of this interface want to do this as a separate step (which
would require changing all the existing users...)?  We're providing an
interface to get the virq mapped to a particular interrupt in the
device, it's not obvious that that is an allocation and it certainly
wasn't the intention (this code predates us using domains).

> So fix need to go in the irq_domain_remove() to unamp before actually
> destroying the irq domain?

That's one option, but you could also do this at the regmap-irq level.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)