lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 08 Feb 2016 23:53:51 +0000 From: Ben Hutchings <ben@...adent.org.uk> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org CC: akpm@...ux-foundation.org, "Vladis Dronov" <vdronov@...hat.com>, "Mauro Carvalho Chehab" <mchehab@....samsung.com>, "Hans Verkuil" <hans.verkuil@...co.com>, "Oliver Neukum" <oneukum@...e.com> Subject: [PATCH 3.2 86/87] [media] usbvision fix overflow of interfaces array 3.2.77-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Oliver Neukum <oneukum@...e.com> commit 588afcc1c0e45358159090d95bf7b246fb67565f upstream. This fixes the crash reported in: http://seclists.org/bugtraq/2015/Oct/35 The interface number needs a sanity check. Signed-off-by: Oliver Neukum <oneukum@...e.com> Cc: Vladis Dronov <vdronov@...hat.com> Signed-off-by: Hans Verkuil <hans.verkuil@...co.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@....samsung.com> [bwh: Backported to 3.2: adjust filename] Signed-off-by: Ben Hutchings <ben@...adent.org.uk> --- drivers/media/video/usbvision/usbvision-video.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/media/video/usbvision/usbvision-video.c +++ b/drivers/media/video/usbvision/usbvision-video.c @@ -1502,6 +1502,13 @@ static int __devinit usbvision_probe(str printk(KERN_INFO "%s: %s found\n", __func__, usbvision_device_data[model].model_string); + /* + * this is a security check. + * an exploit using an incorrect bInterfaceNumber is known + */ + if (ifnum >= USB_MAXINTERFACES || !dev->actconfig->interface[ifnum]) + return -ENODEV; + if (usbvision_device_data[model].interface >= 0) interface = &dev->actconfig->interface[usbvision_device_data[model].interface]->altsetting[0]; else
Powered by blists - more mailing lists