linux-kernel - Re: [PATCH 2/3] clk: WARN_ON about to disable a critical clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Feb 2016 16:43:27 -0800
From:	Michael Turquette <mturquette@...libre.com>
To:	Lee Jones <lee.jones@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:	kernel@...inux.com, maxime.coquelin@...com, sboyd@...eaurora.org,
	maxime.ripard@...e-electrons.com, s.hauer@...gutronix.de,
	geert@...ux-m68k.org, "Lee Jones" <lee.jones@...aro.org>
Subject: Re: [PATCH 2/3] clk: WARN_ON about to disable a critical clock

Quoting Lee Jones (2016-01-18 06:28:50)
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Looks good to me.

Regards,
Mike

> ---
>  drivers/clk/clk.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 835cb85..178b364 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -575,6 +575,9 @@ static void clk_core_unprepare(struct clk_core *core)
>         if (WARN_ON(core->prepare_count == 0))
>                 return;
>  
> +       if (WARN_ON(core->prepare_count == 1 && core->flags & CLK_IS_CRITICAL))
> +               return;
> +
>         if (--core->prepare_count > 0)
>                 return;
>  
> @@ -680,6 +683,9 @@ static void clk_core_disable(struct clk_core *core)
>         if (WARN_ON(core->enable_count == 0))
>                 return;
>  
> +       if (WARN_ON(core->enable_count == 1 && core->flags & CLK_IS_CRITICAL))
> +               return;
> +
>         if (--core->enable_count > 0)
>                 return;
>  
> -- 
> 1.9.1
>