linux-kernel - Re: [PATCH] perf python scripting: Append examples to err msg about audit-libs-python

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Feb 2016 19:20:03 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Taeung Song <treeze.taeung@...il.com>
Cc:	linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] perf python scripting: Append examples to err msg about
 audit-libs-python

Em Tue, Feb 09, 2016 at 08:53:10PM +0900, Taeung Song escreveu:
> To print the syscall name, the audit-libs-python package
> should be required. If not installed, print
> the erron string e.g.

After fixing spelling mistakes, applied, thanks,

- Arnaldo

> 
>     # perf script syscall-counts
>     Install the audit-libs-python package to get syscall names.
> 
> But the package name is different in Ubuntu
> so append examples the erron string like below.
> (similar to a error message of util/trace-event-scripting.c)
> 
>     # perf script syscall-counts
>     Install the audit-libs-python package to get syscall names.
>     For example:
>       # apt-get install python-audit (Ubuntu)
>       # yum install audit-libs-python (Fedora)
>       etc.
> 
> Signed-off-by: Taeung Song <treeze.taeung@...il.com>
> ---
>  tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py
> index 15c8400..1d95009 100644
> --- a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py
> +++ b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py
> @@ -71,7 +71,10 @@ try:
>  except:
>  	if not audit_package_warned:
>  		audit_package_warned = True
> -		print "Install the audit-libs-python package to get syscall names"
> +		print "Install the audit-libs-python package to get syscall names.\n" \
> +                    "For example:\n  # apt-get install python-audit (Ubuntu)" \
> +                    "\n  # yum install audit-libs-python (Fedora)" \
> +                    "\n  etc.\n"
>  
>  def syscall_name(id):
>  	try:
> -- 
> 2.5.0