linux-kernel - Re: [PATCH v1 4/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Feb 2016 12:07:08 +0100
From:	Tomeu Vizoso <tomeu.vizoso@...labora.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sameer Nanda <snanda@...omium.org>,
	Benson Leung <bleung@...omium.org>,
	Enric Balletbò <enric.balletbo@...labora.co.uk>,
	Vic Yang <victoryang@...omium.org>,
	Vincent Palatin <vpalatin@...omium.org>,
	Randall Spangler <rspangler@...omium.org>,
	Gwendal Grignou <gwendal@...omium.org>,
	Shawn Nematbakhsh <shawnn@...omium.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Olof Johansson <olof@...om.net>
Subject: Re: [PATCH v1 4/6] power: cros_usbpd-charger: Add EC-based USB PD
 charger driver

On 10 February 2016 at 17:49, Lee Jones <lee.jones@...aro.org> wrote:
> On Fri, 05 Feb 2016, Tomeu Vizoso wrote:
>
>> From: Sameer Nanda <snanda@...omium.org>
>>
>> This driver exposes the charger functionality in the PD EC to userspace.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
>> Cc: Sameer Nanda <snanda@...omium.org>
>> Cc: Benson Leung <bleung@...omium.org>
>> Cc: Shawn Nematbakhsh <shawnn@...omium.org>
>> ---
>>
>>  drivers/platform/chrome/cros_ec_proto.c |  37 ++
>>  drivers/power/Kconfig                   |  10 +
>>  drivers/power/Makefile                  |   1 +
>>  drivers/power/cros_usbpd-charger.c      | 907 ++++++++++++++++++++++++++++++++
>>  include/linux/mfd/cros_ec.h             |  28 +
>>  include/linux/mfd/cros_ec_commands.h    | 324 +++++++++++-
>>  6 files changed, 1302 insertions(+), 5 deletions(-)
>>  create mode 100644 drivers/power/cros_usbpd-charger.c
>
> A 1300 line patch crossing 3 subsystems is not the way you should be
> submitting code.  Please split these up into separate commits.  The
> only time you should squash all this functionality into a single patch
> is to mitigate otherwise unavoidable build issues.  I do not believe
> that's the case here.

Agreed, sorry about that.

Thanks,

Tomeu