lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 12 Feb 2016 14:59:53 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Andy Lutomirski <luto@...capital.net>
Cc:	Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Brian Gerst <brgerst@...il.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Stas Sergeev <stsp@...t.ru>,
	Cyrill Gorcunov <gorcunov@...il.com>,
	Pavel Emelyanov <xemul@...allels.com>
Subject: Re: [PATCH v3 4/4] selftests/x86: Add tests for UC_SIGCONTEXT_SS and
 UC_STRICT_RESTORE_SS

On Thu, Feb 11, 2016 at 04:46:31PM -0800, Andy Lutomirski wrote:
> Too tangled.  Adding:
> 
> #include "../../../../arch/x86/include/asm/desc_defs.h"

Yeah, that's fine. We do those crazy include paths in other tools too:

$ grep -ErIn '(\.\.\/){2,}' tools/
tools/usb/ffs-test.c:42:#include "../../include/uapi/linux/usb/functionfs.h"
tools/perf/bench/mem-memset-x86-64-asm.S:4:#include "../../../arch/x86/lib/memset_64.S"
tools/perf/bench/mem-memcpy-x86-64-asm.S:4:#include "../../../arch/x86/lib/memcpy_64.S"
tools/perf/util/include/asm/byteorder.h:2:#include "../../../../include/uapi/linux/swab.h"
tools/perf/util/include/linux/const.h:1:#include "../../../../include/uapi/linux/const.h"
...

> Complains that u16 isn't a type.  Trying to include types.h doesn't
> work well either.

Add

typedef unsigned short u16;

before the include maybe?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ