linux-kernel - Re: [PATCH 3/3] tpm: Get rid of devname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 13 Feb 2016 09:01:06 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:	kbuild-all@...org,
	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	Stefan Berger <stefanb@...ibm.com>,
	Peter Huewe <peterhuewe@....de>
Subject: Re: [PATCH 3/3] tpm: Get rid of devname

Hi Jason,

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on v4.5-rc3 next-20160212]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Jason-Gunthorpe/tpm-Hold-the-kref-during-tpm_chip_find_get/20160213-080824
config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

   drivers/char/tpm/tpm-chip.c: In function 'tpm1_chip_register':
>> drivers/char/tpm/tpm-chip.c:193:19: warning: passing argument 1 of 'tpm_bios_log_setup' discards 'const' qualifier from pointer target type
     chip->bios_dir = tpm_bios_log_setup(dev_name(&chip->dev));
                      ^
   In file included from drivers/char/tpm/tpm-chip.c:30:0:
   drivers/char/tpm/tpm_eventlog.h:83:31: note: expected 'char *' but argument is of type 'const char *'
    static inline struct dentry **tpm_bios_log_setup(char *name)
                                  ^

vim +193 drivers/char/tpm/tpm-chip.c

   177	{
   178		cdev_del(&chip->cdev);
   179		device_unregister(&chip->dev);
   180	}
   181	
   182	static int tpm1_chip_register(struct tpm_chip *chip)
   183	{
   184		int rc;
   185	
   186		if (chip->flags & TPM_CHIP_FLAG_TPM2)
   187			return 0;
   188	
   189		rc = tpm_sysfs_add_device(chip);
   190		if (rc)
   191			return rc;
   192	
 > 193		chip->bios_dir = tpm_bios_log_setup(dev_name(&chip->dev));
   194	
   195		return 0;
   196	}
   197	
   198	static void tpm1_chip_unregister(struct tpm_chip *chip)
   199	{
   200		if (chip->flags & TPM_CHIP_FLAG_TPM2)
   201			return;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (44085 bytes)