linux-kernel - Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 13 Feb 2016 11:12:45 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kernel-testers@...r.kernel.org,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Helmut Buchsbaum <helmut.buchsbaum@...il.com>
Subject: Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO

On Fri, Feb 12, 2016 at 11:18 AM, Sudip Mukherjee
<sudipm.mukherjee@...il.com> wrote:
> The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing
> with the error:
>  drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value'
>  drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc'

Does that file include include/linux/gpio/consumer.h?
The GPIO subsystem provides dummies of these functions when CONFIG_GPIOLIB=n.

> GPIO is now used to reset the switch so we should have a dependency on
> GPIOLIB.
>
> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")
> Cc: Helmut Buchsbaum <helmut.buchsbaum@...il.com>
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
>  drivers/net/phy/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index f0a7702..c6a4fe1 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -261,4 +261,4 @@ endif # PHYLIB
>
>  config MICREL_KS8995MA
>         tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch"
> -       depends on SPI
> +       depends on SPI && GPIOLIB

I think that can become

    depends on SPI
    depends on GPIOLIB || COMPILE_TEST

after you've added the missing include.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds