linux-kernel - Re: [PATCH 3/3] net: mvpp2: Return correct error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 13 Feb 2016 05:58:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	amitoj1606@...il.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	julia.lawall@...6.fr
Subject: Re: [PATCH 3/3] net: mvpp2: Return correct error codes

From: Amitoj Kaur Chawla <amitoj1606@...il.com>
Date: Thu, 4 Feb 2016 19:25:26 +0530

> The return value of kzalloc on failure of allocation of memory should
> be -ENOMEM and not -1.
> 
> Found using Coccinelle. A simplified version of the semantic patch
> used is:
 ...
> This function may also return -1 after calling mpp2_prs_tcam_port_map_get.
> So that the function consistently returns meaningful error values on 
> failure, the -1 is changed to -EINVAL.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>

Applied.