linux-kernel - Re: [PATCH net] net: dsa: mv88e6xxx: do not leave reserved VLANs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 13 Feb 2016 06:08:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	vivien.didelot@...oirfairelinux.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...oirfairelinux.com, andrew@...n.ch,
	kevin.smith@...csyscorp.com
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: do not leave reserved VLANs

From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Date: Fri,  5 Feb 2016 14:07:14 -0500

> BRIDGE_VLAN_FILTERING automatically adds a newly bridged port to the
> VLAN with the bridge's default_pvid.
> 
> The mv88e6xxx driver currently reserves VLANs 4000+ for unbridged ports
> isolation. When a port joins a bridge, it leaves its reserved VLAN. When
> a port leaves a bridge, it joins again its reserved VLAN.
> 
> But if the VLAN filtering is disabled, or if this hardware VLAN is
> already in use, the bridged port ends up with no default VLAN, and the
> communication with the CPU is thus broken.
> 
> To fix this, make a port join its reserved VLAN once on setup, never
> leave it, and restore its PVID after another one was eventually used.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Applied.