linux-kernel - Re: [PATCH v3 5/5] Staging: rtl8188eu/core: make core more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 14 Feb 2016 16:39:49 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Colin Vidal <colin@...dal.org>
Cc:	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 5/5] Staging: rtl8188eu/core: make core more readable

On Fri, Feb 12, 2016 at 07:05:53PM +0100, Colin Vidal wrote:
> Signed-off-by: Colin Vidal <colin@...dal.org>
> ---
>  drivers/staging/rtl8188eu/core/rtw_iol.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c
> index 2e2145c..ba6c492 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_iol.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_iol.c
> @@ -18,11 +18,7 @@
>  
>  bool rtw_IOL_applied(struct adapter *adapter)
>  {
> -	if (adapter->registrypriv.fw_iol == 1)
> -		return true;
> -
> -	if ((adapter->registrypriv.fw_iol == 2) &&
> -	    (!adapter_to_dvobj(adapter)->ishighspeed))
> -		return true;
> -	return false;
> +	return adapter->registrypriv.fw_iol == 1 ||
> +		(adapter->registrypriv.fw_iol == 2 &&
> +		 !adapter_to_dvobj(adapter)->ishighspeed);
>  }

I'm sorry, but this patch does not do what you said it does, it's much
harder to read now :(

Also, I can't take a patch without a changelog text :(

thanks,

greg k-h