linux-kernel - Re: [PATCH] usb: dwc2: host: fix the data toggle error in full speed descriptor dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 01:35:28 +0000
From:	John Youn <John.Youn@...opsys.com>
To:	Jianqiang Tang <jianqiang.tang@...el.com>,
	John Youn <John.Youn@...opsys.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dyson Lee <dyson.lee@...el.com>
Subject: Re: [PATCH] usb: dwc2: host: fix the data toggle error in full
 speed descriptor dma

On 1/25/2016 10:20 PM, Jianqiang Tang wrote:
> From: "Tang, Jianqiang" <jianqiang.tang@...el.com>
> 
> There will be data toggle error happen for full speed buld-out transfer.
> The data toggle bit is saved in qh for non-control transfers, it is wrong
> to  check the qtd for that case.
> 
> Also fix one static analysis tool issue after fix the data toggle error.
> 
> Signed-off-by: Dyson Lee <dyson.lee@...el.com>
> Signed-off-by: Tang, Jianqiang <jianqiang.tang@...el.com>
> ---
>  drivers/usb/dwc2/hcd_ddma.c | 2 +-
>  drivers/usb/dwc2/hcd_intr.c | 4 ++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc2/hcd_ddma.c b/drivers/usb/dwc2/hcd_ddma.c
> index 36606fc..6b18956 100644
> --- a/drivers/usb/dwc2/hcd_ddma.c
> +++ b/drivers/usb/dwc2/hcd_ddma.c
> @@ -1258,7 +1258,7 @@ static void dwc2_complete_non_isoc_xfer_ddma(struct dwc2_hsotg *hsotg,
>  		 */
>  		if (halt_status == DWC2_HC_XFER_STALL)
>  			qh->data_toggle = DWC2_HC_PID_DATA0;
> -		else if (qtd)
> +		else
>  			dwc2_hcd_save_data_toggle(hsotg, chan, chnum, qtd);
>  	}
>  
> diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c
> index f825380..918773f 100644
> --- a/drivers/usb/dwc2/hcd_intr.c
> +++ b/drivers/usb/dwc2/hcd_intr.c
> @@ -530,6 +530,10 @@ void dwc2_hcd_save_data_toggle(struct dwc2_hsotg *hsotg,
>  		else
>  			chan->qh->data_toggle = DWC2_HC_PID_DATA1;
>  	} else {
> +		if (!qtd) {
> +			dev_err(hsotg->dev, "qtd is null, return\n");
> +			return;
> +		}
>  		if (pid == TSIZ_SC_MC_PID_DATA0)
>  			qtd->data_toggle = DWC2_HC_PID_DATA0;
>  		else
> 

Thanks for this. I've applied this internally for testing and added
WARNs in the dwc2_hcd_save_data_toggle function(). I will resend for
review along with another fix that we have for DDMA in that same area.

Regards,
John