linux-kernel - Re: [PATCH v2] qxl: use kmalloc_array to alloc reloc_info in qxl_process_single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 15:23:33 +0100
From:	Daniel Vetter <daniel@...ll.ch>
To:	Gerd Hoffmann <kraxel@...hat.com>
Cc:	David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
	stable@...r.kernel.org, gnomes@...rguk.ukuu.org.uk,
	"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] qxl: use kmalloc_array to alloc reloc_info in
 qxl_process_single_command

On Tue, Feb 16, 2016 at 02:25:00PM +0100, Gerd Hoffmann wrote:
> This avoids integer overflows on 32bit machines when calculating
> reloc_info size, as reported by Alan Cox.
> 
> Cc: stable@...r.kernel.org
> Cc: gnomes@...rguk.ukuu.org.uk
> Signed-off-by: Gerd Hoffmann <kraxel@...hat.com>

Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>

> ---
>  drivers/gpu/drm/qxl/qxl_ioctl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c b/drivers/gpu/drm/qxl/qxl_ioctl.c
> index 2ae8577..7c2e782 100644
> --- a/drivers/gpu/drm/qxl/qxl_ioctl.c
> +++ b/drivers/gpu/drm/qxl/qxl_ioctl.c
> @@ -168,7 +168,8 @@ static int qxl_process_single_command(struct qxl_device *qdev,
>  		       cmd->command_size))
>  		return -EFAULT;
>  
> -	reloc_info = kmalloc(sizeof(struct qxl_reloc_info) * cmd->relocs_num, GFP_KERNEL);
> +	reloc_info = kmalloc_array(cmd->relocs_num,
> +				   sizeof(struct qxl_reloc_info), GFP_KERNEL);
>  	if (!reloc_info)
>  		return -ENOMEM;
>  
> -- 
> 1.8.3.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch