linux-kernel - Re: [PATCH] [media] v4l2-async: Don't fail if registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 17:00:46 -0300
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Benoit Parrot <bparrot@...com>
Cc:	linux-kernel@...r.kernel.org, Sakari Ailus <sakari.ailus@....fi>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Bryan Wu <cooloney@...il.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	linux-media@...r.kernel.org
Subject: Re: [PATCH] [media] v4l2-async: Don't fail if registered_async isn't
 implemented

Hello Benoit,

On 02/16/2016 04:53 PM, Benoit Parrot wrote:
> Javier Martinez Canillas <javier@....samsung.com> wrote on Tue [2016-Feb-16 15:51:05 -0300]:
>> After sub-dev registration in v4l2_async_test_notify(), the v4l2-async
>> core calls the registered_async callback but if a sub-dev driver does
>> not implement it, v4l2_subdev_call() will return a -ENOIOCTLCMD which
>> should not be considered an error.
>>
>> Reported-by: Benoit Parrot <bparrot@...com>
>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>>
>> ---
>>
>>   drivers/media/v4l2-core/v4l2-async.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
>> index 716bfd47daab..4d809115ba49 100644
>> --- a/drivers/media/v4l2-core/v4l2-async.c
>> +++ b/drivers/media/v4l2-core/v4l2-async.c
>> @@ -113,7 +113,7 @@ static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier,
>>   	list_move(&sd->async_list, &notifier->done);
>>
>>   	ret = v4l2_device_register_subdev(notifier->v4l2_dev, sd);
>> -	if (ret < 0) {
>> +	if (ret < 0 && ret != -ENOIOCTLCMD) {
>
> NAK.
> This fix should be on the next if block.
> The one that actually invokes the registered_async call back.

Yeah, that's actually what the commit says but I'm too stupid
to write a one line patch... I'll send a v2.

> As is it does not help.
>

Sorry about that, I shouldn't post patches in a rush.

> Benoit
>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America