linux-kernel - Re: [PATCH 1/1 v2] MIPS: DTS: cavium-octeon: provide model attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 16:20:19 -0800
From:	David Daney <ddaney.cavm@...il.com>
To:	Heinrich Schuchardt <xypron.glpk@....de>
CC:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Andrew Bresticker <abrestic@...omium.org>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Arnd Bergmann <arnd@...db.de>, devicetree@...r.kernel.org,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 v2] MIPS: DTS: cavium-octeon: provide model attribute

On 02/15/2016 10:35 AM, Heinrich Schuchardt wrote:
> Downstream packages like Debian flash-kernel rely on
> /proc/device-tree/model
> to determine how to install an updated kernel image.
>
> Most dts files provide this property.
>
> This patch adds a model attribute Octeon CPUs.
>
> v2:
> 	Use vendor prefix defined in vendor-prefixes.txt.
> 	Separate model from vendor by comma.
> 	Avoid wildcards.
>
> Cc: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>


NAK.

These device tree templates are only used on systems with archaic 
versions of u-boot.  For all modern OCTEON systems, the device tree is 
provided by the firmware and is not under the control of the authors of 
the Linux kernel.

Whatever problem you are attempting to solve, almost by definition, 
cannot be solved by modifying these files.

We are worse off changing these, and giving people false hope that you 
are fixing something, than doing nothing.

David Daney



> ---
>   arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts | 1 +
>   arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> index 9c48e05..f70cd58 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_3xxx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-3860";
> +	model = "cavium,Octeon 3860";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu>;
> diff --git a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> index 79b46fc..0b40899 100644
> --- a/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> +++ b/arch/mips/boot/dts/cavium-octeon/octeon_68xx.dts
> @@ -8,6 +8,7 @@
>    */
>   / {
>   	compatible = "cavium,octeon-6880";
> +	model = "cavium,Octeon 6880";
>   	#address-cells = <2>;
>   	#size-cells = <2>;
>   	interrupt-parent = <&ciu2>;
>