linux-kernel - Re: [PATCH] kernel/hung_task.c: printk address for hung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Feb 2016 15:17:10 +0800
From:	Kassey <kassey1216@...il.com>
To:	Pan Xinhui <xinhui@...ux.vnet.ibm.com>, oleg@...hat.com,
	msb@...gle.com, mingo@...e.hu
Cc:	mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/hung_task.c: printk address for hung_task

Ingo, Mandeep:
         can you review this patch ?
BR
Kassey

On Thu, Jan 14, 2016 at 5:33 PM, Kassey <kassey1216@...il.com> wrote:
> Xinhui:
>       when I got a  DDR dump, with the task_struct address for this
> task, I can see what file this task is accessing, as well as
> task_struct member.
>       this is very useful and popular on arch where we can generate a
> DDR dump when system crash.
>
> BR
> Kassey
>
> On Thu, Jan 14, 2016 at 10:45 AM, Pan Xinhui <xinhui@...ux.vnet.ibm.com> wrote:
>> hi, Li
>>         I have a little confusion. for what you want to know this ptr's value. Can that help you debug or root the cause?
>> I'm just wondering :)
>>
>> thanks
>> xinhui
>>
>> On 2016年01月13日 10:42, Li wrote:
>>> From: Kassey Li <kassey1216@...il.com>
>>>
>>> this is used to check task_struct info when got a dump.
>>>
>>> Signed-off-by: Kassey Li <kassey1216@...il.com>
>>> ---
>>>  kernel/hung_task.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/kernel/hung_task.c b/kernel/hung_task.c
>>> index d234022..b5dd7dd 100644
>>> --- a/kernel/hung_task.c
>>> +++ b/kernel/hung_task.c
>>> @@ -108,8 +108,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
>>>        * Ok, the task did not get scheduled for more than 2 minutes,
>>>        * complain:
>>>        */
>>> -     pr_err("INFO: task %s:%d blocked for more than %ld seconds.\n",
>>> -             t->comm, t->pid, timeout);
>>> +     pr_err("INFO: task %s:%d 0x%p blocked for more than %ld seconds.\n",
>>> +             t->comm, t->pid, t, timeout);
>>>       pr_err("      %s %s %.*s\n",
>>>               print_tainted(), init_utsname()->release,
>>>               (int)strcspn(init_utsname()->version, " "),
>>>
>>
>
>
>
> --
> Best regards
> Kassey



-- 
Best regards
Kassey