lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Feb 2016 02:33:10 +0000 From: Al Viro <viro@...IV.linux.org.uk> To: Andrzej Hajda <a.hajda@...sung.com> Cc: linux-kernel@...r.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Marek Szyprowski <m.szyprowski@...sung.com>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Subject: Re: [PATCH 3/7] drivers: char: mem: fix IS_ERROR_VALUE usage On Mon, Feb 15, 2016 at 03:35:21PM +0100, Andrzej Hajda wrote: > diff --git a/drivers/char/mem.c b/drivers/char/mem.c > index 4f6f94c..71025c2 100644 > --- a/drivers/char/mem.c > +++ b/drivers/char/mem.c > @@ -695,7 +695,7 @@ static loff_t memory_lseek(struct file *file, loff_t offset, int orig) > offset += file->f_pos; > case SEEK_SET: > /* to avoid userland mistaking f_pos=-9 as -EBADF=-9 */ > - if (IS_ERR_VALUE((unsigned long long)offset)) { > + if ((unsigned long long)offset >= -MAX_ERRNO) { > ret = -EOVERFLOW; > break; > } ACK
Powered by blists - more mailing lists