linux-kernel - Re: [PATCH 3/5] dt-bindings: phy: bindings document for common Broadcom SATA3 PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Feb 2016 08:38:15 -0600
From:	Rob Herring <robh@...nel.org>
To:	Anup Patel <anup.patel@...adcom.com>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Brian Norris <computersforpeace@...il.com>,
	Gregory Fong <gregory.0xf0@...il.com>,
	Device Tree <devicetree@...r.kernel.org>,
	Linux ARM Kernel <linux-arm-kernel@...ts.infradead.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, Ray Jui <rjui@...adcom.com>,
	Scott Branden <sbranden@...adcom.com>,
	Jon Mason <jon.mason@...adcom.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH 3/5] dt-bindings: phy: bindings document for common
 Broadcom SATA3 PHY driver

On Tue, Feb 16, 2016 at 12:03:38PM +0530, Anup Patel wrote:
> This patch:
> 1. Renames DT bindings document of Broadcom STB SATA3 PHY driver to
> common Broadcom SATA3 PHY driver bindings document
> 2. Adds bindings info for NS2 SATA3 PHY
> 
> Signed-off-by: Anup Patel <anup.patel@...adcom.com>
> ---
>  .../phy/{brcm,brcmstb-sata-phy.txt => brcm-sata-phy.txt}  | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
>  rename Documentation/devicetree/bindings/phy/{brcm,brcmstb-sata-phy.txt => brcm-sata-phy.txt} (69%)
> 
> diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-sata-phy.txt b/Documentation/devicetree/bindings/phy/brcm-sata-phy.txt
> similarity index 69%
> rename from Documentation/devicetree/bindings/phy/brcm,brcmstb-sata-phy.txt
> rename to Documentation/devicetree/bindings/phy/brcm-sata-phy.txt
> index d87ab7c..d023120 100644
> --- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-sata-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/brcm-sata-phy.txt
> @@ -1,14 +1,17 @@
> -* Broadcom SATA3 PHY for STB
> +* Broadcom SATA3 PHY
>  
>  Required properties:
>  - compatible: should be one or more of
>       "brcm,bcm7425-sata-phy"
>       "brcm,bcm7445-sata-phy"
> +     "brcm,iproc-ns2-sata-phy"
>       "brcm,phy-sata3"
>  - address-cells: should be 1
>  - size-cells: should be 0
> -- reg: register range for the PHY PCB interface
> -- reg-names: should be "phy"
> +- reg: register ranges for the PHY PCB interface
> +- reg-names: should be "phy" and "phy-ctrl"
> +     The "phy-ctrl" registers are only required for
> +     "brcm,iproc-ns2-sata-phy".
>  
>  Sub-nodes:
>    Each port's PHY should be represented as a sub-node.
> @@ -16,12 +19,12 @@ Sub-nodes:
>  Sub-nodes required properties:
>  - reg: the PHY number
>  - phy-cells: generic PHY binding; must be 0
> -Optional:
> -- brcm,enable-ssc: use spread spectrum clocking (SSC) on this port
>  
> +Sub-nodes optional properties:
> +- brcm,enable-ssc: use spread spectrum clocking (SSC) on this port
> +     This property is not applicable for "brcm,iproc-ns2-sata-phy".

My understanding of SSC is it is required for hosts and optional for 
drives to support (from first hand experience of a host not enabling). 
Not setting this is would not be compliant. The polarity on this is 
somewhat backwards too as the common case should be no property.

Anyway, that's all besides the point of your change. I assume it doesn't 
apply here for you because it is always enabled. 

Acked-by: Rob Herring <robh@...nel.org>

Rob