linux-kernel - Re: [PATCH 2/3] thermal: exynos: Use devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Feb 2016 09:33:03 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Javier Martinez Canillas <javier@....samsung.com>,
	linux-kernel@...r.kernel.org
Cc:	linux-arm-kernel@...ts.infradead.org,
	Kukjin Kim <kgene@...nel.org>, linux-pm@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	Lukasz Majewski <l.majewski@...sung.com>,
	Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>
Subject: Re: [PATCH 2/3] thermal: exynos: Use devm_regulator_get_optional() for
 vtmu

On 19.02.2016 03:19, Javier Martinez Canillas wrote:
> The Exynos TMU DT binding says that the vtmu-supply is optional but the
> driver uses devm_regulator_get() that creates a dummy regulator if it's
> not defined in the DT. For example the following message is in the log:
> 
> 10060000.tmu supply vtmu not found, using dummy regulator
> 
> Use the optional version of regulator_get() that doesn't create a dummy
> regulator and instead returns a -ENODEV errno code. Since it's expected
> that a regulator may not be defined and the driver will inform about it:
> 
> exynos-tmu 10060000.tmu: Regulator node (vtmu) not found
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> ---
> 
>  drivers/thermal/samsung/exynos_tmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Best regards,
Krzysztof