linux-kernel - Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 21 Feb 2016 23:42:44 +0000
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Andrej Krpic <ak77@...de.com>
Cc:	linux-kernel@...r.kernel.org, jslaby@...e.com,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH 0/8] tty: n_gsm: Make mux work as a responder station

On Sun, 21 Feb 2016 22:38:29 +0100
Andrej Krpic <ak77@...de.com> wrote:

> When using n_gsm you have to explicitly set it to work as a initiator
> station. This led me to believe that it can also work as a responder.
> 
> In a use case where I needed responder station mux I came to the
> conclusion that it actually does not work. Second and third patch
> fix dealings with frame C/R bit that then enable mux to work as a
> responder station.
> 
> Next patches in the series then fix bugs that were found after two 
> instances of n_gsm connected over null-modem cable were used.
> 
> First patch fixes formatting errors, such as space before comma, and
> most of the warnings reported by the checkpatch script.

This looks reasonable to me. It was never intended to work as a responder
but it seems clean enough to do so. Have you tested it against some other
modems with these changes applied ?

(I'm always wary of patches to this going in without testing on actual
modems, because the spec is complex and we are not the only ones with
bugs)

Also can you please cc these patches to
	xinhuix.pan@...el.com

Thanks

Alan