linux-kernel - Re: [PATCH] jme: remove the jme driver as it is no longer maintained

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 22 Feb 2016 22:38:30 -0300
From:	Diego Viola <diego.viola@...il.com>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org, davem@...emloft.net,
	netdev@...r.kernel.org, cooldavid@...ldavid.org
Subject: Re: [PATCH] jme: remove the jme driver as it is no longer maintained

On Sun, Feb 21, 2016 at 2:17 PM, Diego Viola <diego.viola@...il.com> wrote:
> On Sun, Feb 21, 2016 at 9:45 AM, One Thousand Gnomes
> <gnomes@...rguk.ukuu.org.uk> wrote:
>>> I would appreciate some hint from someone who is more experienced with drivers.
>>
>> Start by testing
>>
>> - loading the driver as a module
>> - using the networking
>> - unloading the module (and checking it stays unloaded!)
>>
>> then suspend/resume
>>
>> If that works then you have a good starting point because you know a
>> sequence of actions that suspends properly. If it fails then it's going
>> to be rather more fun because it implies something in the hardware has
>> not been properly shut down.
>>
>> Alan
>
> Hi Alan,
>
> Thanks for your email, did you see my bug report? Because I tried all
> this already.
>
> The only workarounds I've found to work is one of these:
>
> $ rmmod jme # before suspend
>
> or
>
> $ ip link set ens34 down
>
> or
>
> $ echo 0 > /sys/power/pm_async # disable async power management
>
> Then resume works fine (I can't reproduce the hang).
>
> I'm not a C developer nor a kernel developer, I tried looking at the
> jme.c driver code but it's not clear what is broken and what needs
> fixing, so I would appreciate someone more experienced looking at the
> issue and giving me an idea or two.
>
> Thanks,
> Diego

Please disregard this patch, I feel like an idiot for sending it.

I've found a fix already and sent a patch.

Diego