linux-kernel - RE: [PATCH v2] Bluetooth: hci_uart: Support firmware download for Marvell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Feb 2016 14:49:02 +0000
From:	Amitkumar Karwar <akarwar@...vell.com>
To:	Marcel Holtmann <marcel@...tmann.org>
CC:	BlueZ development <linux-bluetooth@...r.kernel.org>,
	Nishant Sarmukadam <nishants@...vell.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Cathy Luo <cluo@...vell.com>,
	Ganapathi Bhat <gbhat@...vell.com>
Subject: RE: [PATCH v2] Bluetooth: hci_uart: Support firmware download for
 Marvell

Hi Marcel,

> From: Marcel Holtmann [mailto:marcel@...tmann.org]
> Sent: Saturday, February 20, 2016 1:37 PM
> To: Amitkumar Karwar
> Cc: BlueZ development; Nishant Sarmukadam; linux-kernel@...r.kernel.org;
> Cathy Luo; Ganapathi Bhat
> Subject: Re: [PATCH v2] Bluetooth: hci_uart: Support firmware download
> for Marvell
> 
> Hi Amitkumar,
> 
> > This patch implement firmware download feature for Marvell Bluetooth
> > devices. If firmware is already downloaded, it will skip downloading.
> >
> > Signed-off-by: Ganapathi Bhat <gbhat@...vell.com>
> > Signed-off-by: Amitkumar Karwar <akarwar@...vell.com>
> > ---
> > v2: Fixed compilation warning reported by kbuild test robot
> > ---

Thanks for your review.
We are able to resolve all your comments. We are now checking how can we avoid firmware and helper file name global variables and module parameters.

Regards,
Amitkumar