linux-kernel - Re: [PATCH] spi/rockchip: Make sure spi clk is on in rockchip_spi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2016 10:58:29 +0900
From:	Mark Brown <broonie@...nel.org>
To:	"Huang, Tao" <huangtao@...k-chips.com>
Cc:	Huibin Hong <huibin.hong@...k-chips.com>,
	linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
	"shawn.lin" <shawn.lin@...nel-upstream.org>,
	linux-rockchip@...ts.infradead.org, Addy Ke <addy.ke@...kchip.com>
Subject: Re: [PATCH] spi/rockchip: Make sure spi clk is on in
 rockchip_spi_set_cs

On Wed, Feb 24, 2016 at 07:09:57PM +0800, Huang, Tao wrote:

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

> Another way to solve this bug is add runtime PM support while spi setup.
> Some other chips may have some problem, for example mt65xx and orion,
> which access hardware register too.

No, this is telling you you're doing something wrong - setup() might be
called while another transfer is in progress so you shouldn't be
changing the hardware setup (see Documentation/spi/spi-summary).  This
means that you normally shouldn't be writing to registers there.  Moving
this to prepare_message() instead is probably what you want.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)