linux-kernel - Re: [PATCH 1/1] mm: thp: Redefine default THP defrag behaviour disable it by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2016 10:52:30 +0000
From:	Mel Gorman <mgorman@...hsingularity.net>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Vlastimil Babka <vbabka@...e.cz>,
	Rik van Riel <riel@...hat.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] mm: thp: Redefine default THP defrag behaviour
 disable it by default

On Thu, Feb 25, 2016 at 02:45:24PM -0500, Johannes Weiner wrote:
> > THP gives impressive gains in some cases but only if they are quickly
> > available.  We're not going to reach the point where they are completely
> > free so lets take the costs out of the fast paths finally and defer the
> > cost to kswapd, kcompactd and khugepaged where it belongs.
> > 
> > Signed-off-by: Mel Gorman <mgorman@...hsingularity.net>
> 
> Acked-by: Johannes Weiner <hannes@...xchg.org>
> 
> The cornercases Rik pointed out aside, if the mapping isn't long-lived
> enough that it can wait for khugepaged, what are the odds that the
> defrag work will be offset by the TLB savings? However, for mappings
> where it would pay off, having to do the same defrag work but doing it
> at a later time is actually a net loss. Should we consider keeping
> direct reclaim and compaction as a configurable option as least?
> 

Yes, I think so. I've a prototype now that makes it configurable and am
running some tests. I'll preserve your and Rik's ack in V2 as the patch
will be different but the default behaviour will be very similar.

-- 
Mel Gorman
SUSE Labs