linux-kernel - Re: [PATCH] modsign: hide openssl output in silent builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2016 11:20:28 +0000
From:	David Howells <dhowells@...hat.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	dhowells@...hat.com, David Woodhouse <dwmw2@...radead.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kbuild@...r.kernel.org,
	Michal Marek <mmarek@...e.com>, keyrings@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] modsign: hide openssl output in silent builds

Arnd Bergmann <arnd@...db.de> wrote:

> When a user calls 'make -s', we can assume they don't want to
> see any output except for warnings and errors, but instead
> they see this for a warning free build:
> 
>  ###
>  ### Now generating an X.509 key pair to be used for signing modules.
>  ###
>  ### If this takes a long time, you might wish to run rngd in the
>  ### background to keep the supply of entropy topped up.  It
>  ### needs to be run as root, and uses a hardware random
>  ### number generator if one is available.
>  ###
>  Generating a 4096 bit RSA private key
>  .................................................................................................................................................................................................................................++
>  ..............................................................................................................................++
>  writing new private key to 'certs/signing_key.pem'
>  -----
>  ###
>  ### Key pair generated.
>  ###
> 
> The output can confuse simple build testing scripts that just check
> for an empty build log.
> 
> This patch silences all the output:
>  - "echo" is changed to "@$(kecho)", which is dropped when "-s" gets
>    passed
>  - the openssl command itself is only printed with V=1, using the
>    $(Q) macro
>  - The output of openssl gets redircted to /dev/null on "-s" builds.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.

David