linux-kernel - Re: [PATCH v6 0/8] Additional kmsg devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2016 14:22:42 +0100
From:	Kazimierz Krosman <k.krosman@...sung.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	akpm@...ux-foundation.org, peter@...leysoftware.com,
	vvs@...tuozzo.com, corbet@....net, arnd@...db.de, pmladek@...e.cz,
	gregkh@...uxfoundation.org, daniel@...que.org,
	kay.sievers@...y.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-api@...r.kernel.org,
	k.lewandowsk@...sung.com, m.niesluchow@...sung.com,
	richard.weinberger@...il.com, b.zolnierkie@...sung.com,
	luto@...capital.net, knhoon.baik@...sung.com
Subject: Re: [PATCH v6 0/8] Additional kmsg devices

On 02/25/2016 10:47 PM, Tejun Heo wrote:
> I'm not sure this is the right layer to implement generic logging
> facility.
In general this patches add only one feature- possibility of adding and 
deleting
new kmsg devices, so I think that it can be treated as kmsg upgrade.
>> 2. Using kmsg can cause lower CPU utilisation in the real-word use case than
>> >userspace logging mechanisms.
>> >We created 2 tests: (1) 100 writer processes write to created kmsg buffer and
>> >(2) 100 writers write to socket (stream)- there is one reader to protect
>> >socket buffer against overflow. Tests show that cpu utilisation in case of first
>> >test is about 2.3 times lower (39.1%) than it is in second case (87.7%) (measured
>> >with top program; tests code is attached below). Tested on Odroid XU4.
> This sounds like a generic IPC problem than anything else.

For the test purpose I've written two tests (attached in cover letter). 
I think that tests
show that in this use case (multiple writers) system with additional 
kmsg devices
consumes less CPU time than system which use sockets for logging. 
Logging system
based on sockets needs read process, that continuously reads socket and 
protects
against socket buffers overflow and messages drop. It is one of 
advantages of this
solution: no maintenance.

Could you explain in more detail what did you mean by IPC problems?

Thanks.

-- 
Kazimierz Krosman

Samsung R&D Institute Poland
Samsung Electronics
k.krosman@...sung.com