linux-kernel - Re: [PATCH] regmap: irq: Enable irq retriggering for nested irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2016 11:05:55 -0600
From:	Nishanth Menon <nm@...com>
To:	Grygorii Strashko <grygorii.strashko@...com>,
	Mark Brown <broonie@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>
CC:	Lee Jones <lee.jones@...aro.org>,
	Laxman Dewangan <ldewangan@...dia.com>,
	Sekhar Nori <nsekhar@...com>
Subject: Re: [PATCH] regmap: irq: Enable irq retriggering for nested irqs

On 02/26/2016 09:53 AM, Grygorii Strashko wrote:
> When nested interrupts are handled with regmap irq framework, we need to
> mark the interrupts to be resend for pending interrupts on enable_irq.
> Else the events might be lost for nested irqs.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> ---
>  drivers/base/regmap/regmap-irq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
> index 9b0d202..8d9004d 100644
> --- a/drivers/base/regmap/regmap-irq.c
> +++ b/drivers/base/regmap/regmap-irq.c
> @@ -379,6 +379,7 @@ static int regmap_irq_map(struct irq_domain *h, unsigned int virq,
>  	irq_set_chip_data(virq, data);
>  	irq_set_chip(virq, &data->irq_chip);
>  	irq_set_nested_thread(virq, 1);
> +	irq_set_parent(virq, data->irq);
>  	irq_set_noprobe(virq);
>  
>  	return 0;
> 

This is part of the fixes seen to be needed for VBUS irq over Palmas
seen on BeagleBoard-X15.

this patch was part of an internal series which finally resolved the
crash (and associated hang) on X15 resume path.

Tested-by: Nishanth Menon <nm@...com>

-- 
Regards,
Nishanth Menon